[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] x86: s3: write_msi_msg: entry->msg should be in the compatibility format



When Interrupt Remapping is used, after Dom0 S3, Dom0's filesystem might
become inaccessible as the SATA disk's MSI interrupt becomes buggy.
The cause is:
After set_msi_affinity() or setup_msi_irq() invokes write_msi_msg(),
entry->msg records the remappable format message; during S3 resume, Dom0
invokes the PHYSDEVOP_restore_msi hypercall to restore the MSI registers of
devices, and in pci_restore_msi_state() -> write_msi_msg(), the 'entry->msg'
of remappable format is passed, but in write_msi_msg() -> ... ->
msi_msg_to_remap_entry(), the 'msg' is assumed to be in compatibility format.
As a result, after s3, the IRTE is corrupted.

Actually the only users of 'entry->msg' are pci_restore_msi_state() and
dump_msi(). That's why we don't have issue except Dom0 S3.

Thanks,
-- Dexuan

Attachment: fix_s3_when_ir_and_msi_are_used.patch
Description: fix_s3_when_ir_and_msi_are_used.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.