[Xen-devel] Re: [PATCH][v5] PV extension of HVM(hybrid) in support in Xen

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

Hi,

Given that we now have a similar feature from Stefano I'd like to see
them resolved into a single patchset. 

At 09:37 +0000 on 04 Mar (1267695434), Sheng Yang wrote:
> +     if (a.flags & HVM_PV_CLOCK) {
> +             d->hvm_pv_enabled |= XEN_HVM_PV_CLOCK_ENABLED;
> +             update_domain_wallclock_time(d);
> +             /* Other vcpus are adjusted during the start-up */
> +             hvm_funcs.set_tsc_offset(d->vcpu[0], 0);
> +     }

This still makes no sense to me.  Either it should affect the calling
vcpu (i.e., current) or it should affect all online vcpus.

Also, whatever the semantics, they should be documented in comments in
the header file.

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel