Re: [Xen-devel] [PATCH 4 of 4] Linux pvops: xen pci platform device driver

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 3 Mar 2010, Bastian Blank wrote:
> > During the initialization of the xen pci device driver, we write to a
> > magic ioport that causes qemu to unplug some emulated devices, disc and
> > network in particular.
> > This parameter is meant to present the user a choice about what emulated
> > devices to unplug.
> 
> Somehow I don't think this belongs here. It looks like a workaround, you
> can always ask qemu to not bind them at the beginning and the guest
> system to not provide drivers.
> 

Most of the time you just want to unplug all or nothing, so removing the
option is generally not a problem.
However it can still be useful for debugging: let's say that blkfront
doesn't work properly, if the xen pci platform driver unplugs the IDE
disk at init time the guest won't be able to boot.
This fact just made me realize that the xen pci platform driver should
depend on netfront and blkfront too if we make "unplug all" the default.


> > > > +#define XEN_IOPORT_BASE 0x10
> > > 
> > > Why are this constants defined in the driver themself? They only make
> > > sense if there are two components making use of them.
> > Yep, the other one is qemu.
> 
> Well, if it is a published interface move it into a header file.
> 

Good idea


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel