RE: [Xen-devel] x2apic mode vs. interrupt remapping

["Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>]

Jan Beulich wrote:
>>>> "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx> 03.03.10 15:09 >>>
>> When iommu_supports_eim is called in enable_x2apic, drhd is already
>> parsed in acpi_boot_init,
> 
> Provided there is any - in the given case there is none. Perhaps the
> function should also return 0 if the list of drhd-s is empty?

Yeah, if the drhd list is empty, it should return 0 instead of the default 1.  
The condition check maybe need enhancement. 
Xiantao


>> so iommu_supports_eim should return hardware's real capability. That
>> is to say, if eim is no supported on platform, x2apic shouldn't be
>> enabled at all.
> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel