[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] paging_domctl() missing break statements?

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Wed, 17 Feb 2010 09:48:15 +0000
Delivery-date: Wed, 17 Feb 2010 01:49:02 -0800
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

The main switch statement in that function looks suspicious, and with no
explicit comment saying that fall-through is intended it would seem like
one or two break statements are actually missing. Comments?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

Follow-Ups:
- Re: [Xen-devel] paging_domctl() missing break statements?
  - From: Tim Deegan

Prev by Date: Re: SOLVED: Re: [Xen-devel] Issue with pv_ops Kernel 2.6.31.6 and Xen [yinghai@xxxxxxxxxx: [PATCH 01/35] x86: fix sci on ioapic 1]
Next by Date: Re: [Xen-devel] paging_domctl() missing break statements?
Previous by thread: [Xen-devel] Problems with fglrx
Next by thread: Re: [Xen-devel] paging_domctl() missing break statements?
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.