Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2010-01-28 at 22:37 +0000, Daniel Stodden wrote:
>   - Does a runtime kernel version check. I guess this code will
>     need additional cpp magic on BSDs. 

I guess BSD will need cpp magic regardless of the kernel version check
since it will have a different interface altogether. But for the Linux
version can we not just try eventfd(), check for -ENOSYS and fall back
to the old way if necessary, instead of hardcoding the kernel version?

I suppose eventfd is an unlikely candidate for backporting to anything
older but in general IMHO it's preferable to check for the actual
functionality you want to use rather than hardcoding version numbers
etc.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel