[Xen-devel] [PATCH 5/5] input: make xenbus device id constant

[NÃmeth MÃrton <nm127@xxxxxxxxxxx>]

From: MÃrton NÃmeth <nm127@xxxxxxxxxxx>

The ids field of the struct xenbus_device_id is constant in <linux/xen/xenbus.h>
so it is worth to make xenkbd_ids also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
        struct I1 {
          ...
          const struct I2 *x;
          ...
        };
@s@
identifier r.I1, y;
identifier r.x, E;
@@
        struct I1 y = {
          .x = E,
        };
@c@
identifier r.I2;
identifier s.E;
@@
        const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+       const
        struct I2 E[] = ...;
// </smpl>

Signed-off-by: MÃrton NÃmeth <nm127@xxxxxxxxxxx>
Cc: Julia Lawall <julia@xxxxxxx>
Cc: cocci@xxxxxxx
---
diff -u -p a/drivers/input/xen-kbdfront.c b/drivers/input/xen-kbdfront.c
--- a/drivers/input/xen-kbdfront.c 2010-01-07 19:08:40.000000000 +0100
+++ b/drivers/input/xen-kbdfront.c 2010-01-08 19:23:27.000000000 +0100
@@ -321,7 +321,7 @@ InitWait:
        }
 }

-static struct xenbus_device_id xenkbd_ids[] = {
+static const struct xenbus_device_id xenkbd_ids[] = {
        { "vkbd" },
        { "" }
 };

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel