[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] Re: A question about changeset 20621:f9392f6eda79 and Discontinuous online node




>-----Original Message-----
>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>Sent: Wednesday, January 06, 2010 5:45 PM
>To: Keir Fraser; Jiang, Yunhong; andre.przywara@xxxxxxx
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-devel] Re: A question about changeset 20621:f9392f6eda79 and
>Discontinuous online node
>
>On 06/01/2010 09:28, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
>
>>> Keir, thanks for pointing out this.The API is sufficient. We only need
>>> changes
>>> to python side to understand this. One minor thing is, maybe we need change
>>> the nr_nodes from number of online node to the maxium of online node id,
>>> otherwise, xc.physinfo may have no idea when iterate the node_to_memory
>>> information (will it be possible the a node has only memory populated, while
>>> no CPU populated?)
>>
>> Yes, I think actually that would be a bug fix, given how tools currently use
>> the nr_nodes field. Feel free to send a patch as part of your fix-up work: I
>> don't think even changing the field name is necessary, but we can add a
>> comemnt to sysctl.h.
>
>Actually I think we should change the nr_cpus field in the same way, and may
>as well change their names to max_cpu_id and max_node_id. I'll look into
>this myself.

Why we need change the nr_cpus? It has max_cpu_id already.
Thanks that you will look into this.

--jyh

>
> -- Keir
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.