[Xen-devel] Re: [PATCH] libxenlight: implement libxl_set_memory_target

[Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>]

Errrr, no.
http://xenbits.xen.org/xen-unstable.hg?file/8f304c003af4/tools/libxl/libxl.c 
shows that the videoram node will be set only if we are using a 
device-model. And specifically if we are in fully virtualized mode, i.e. 
dm_info->type == XENFV, i.e. *not* PV
Andres
Stefano Stabellini wrote:
> On Wed, 9 Dec 2009, Andres Lagar-Cavilla wrote:
>   
> > Stefano Stabellini wrote:
> >     
> > > On Tue, 8 Dec 2009, Andres Lagar-Cavilla wrote:
> > >   
> > >       
> > > > Hi,
> > > > couple of comments:
> > > > - PV domains without videoram won't be able to use this
> > > >     
> > > >         
> > > PV domains just have videoram = 0.
> > >   
> > >       
> > But you abort libxl_set_memory_target if the videoram node is not found. 
> > Which won't be for PVs with no videoram...
> > +    videoram_s = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, 
> > "%s/memory/videoram", dompath));
> > +    if (!videoram_s)
> > +        return -1;
> >
> >     
> The videoram node will be found, and the value will be 0.
>
>   

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel