[Xen-devel] Re: [PATCH 3/3] xen: rename pciback module to xen-pciback.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2009-12-03 at 22:02 +0000, Konrad Rzeszutek Wilk wrote: 
> On Thu, Dec 03, 2009 at 09:56:20PM +0000, ian.campbell@xxxxxxxxxx wrote:
> > pciback is rather generic for a modular distro style kernel.
> 
> Do you have a patch for Xen python stack to check ownership of
> PCI devices to also be 'xen-pciback'?

Ah, it never even occurred to me that such a thing would be necessary.

I think (but I should check) that the sysfs name will remain pciback
since it comes from the .name in struct xenbus_driver. I'm not sure if
it is confusing or not to have the module name be different to the
driver name nor how common it is.

Ian.

> 
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> > ---
> >  drivers/xen/pciback/Makefile |   24 ++++++++++++------------
> >  1 files changed, 12 insertions(+), 12 deletions(-)
> > 
> > diff --git a/drivers/xen/pciback/Makefile b/drivers/xen/pciback/Makefile
> > index 106dae7..38bc123 100644
> > --- a/drivers/xen/pciback/Makefile
> > +++ b/drivers/xen/pciback/Makefile
> > @@ -1,16 +1,16 @@
> > -obj-$(CONFIG_XEN_PCIDEV_BACKEND) += pciback.o
> > +obj-$(CONFIG_XEN_PCIDEV_BACKEND) += xen-pciback.o
> >  
> > -pciback-y := pci_stub.o pciback_ops.o xenbus.o
> > -pciback-y += conf_space.o conf_space_header.o \
> > -        conf_space_capability.o \
> > -        conf_space_capability_vpd.o \
> > -        conf_space_capability_pm.o \
> > -             conf_space_quirks.o
> > -pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o
> > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o
> > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o
> > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o
> > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o
> > +xen-pciback-y := pci_stub.o pciback_ops.o xenbus.o
> > +xen-pciback-y += conf_space.o conf_space_header.o \
> > +            conf_space_capability.o \
> > +            conf_space_capability_vpd.o \
> > +            conf_space_capability_pm.o \
> > +            conf_space_quirks.o
> > +xen-pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o
> > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o
> > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o
> > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o
> > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o
> >  
> >  ifeq ($(CONFIG_XEN_PCIDEV_BE_DEBUG),y)
> >  EXTRA_CFLAGS += -DDEBUG
> > -- 
> > 1.6.5.3
> > 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel