[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/mm: set_p2m_entry() should return 0 on error



At 05:16 +0000 on 27 Nov (1259298997), Kouya Shimura wrote:
> set_p2m_entry() ignores halfway errors.
> It should return 0 on error, shouldn't it?

Since all of its callers discard the return value, it hardly matters. :(
But yes, this patch makes the semantics more sensible. 

> Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

Acked-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>


-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.