Re: [Xen-devel] [PATCH] xapi toolstack (xen-api-libs): fix compile errors

[Andreas Florath <xen@xxxxxxxxxxxx>]

Hello!

One part of the patch is not correct:
The 'stub_get_internal_offset' is used in the xen-api. Sorry for this!
(IMHO the other part - e.g. removing the xb.mli makes sense.)

But:

Then there is the problem of the undefined symbol XS_RESTRICT.

I had a closer look at this and found, that there are (at least) three
different definitions of xsd_sockmsg_type in the current XEN source.
o ./linux-2.6-pvops.git/include/xen/interface/io/xs_wire.h
  18 entries; tail is:
    XS_WATCH_EVENT,
    XS_ERROR,
    XS_IS_DOMAIN_INTRODUCED
o ./xen/include/public/io/xs_wire.h (which IMHO is used in the xc-lib)
  20 entries; tail is:
    XS_WATCH_EVENT,
    XS_ERROR,
    XS_IS_DOMAIN_INTRODUCED,
    XS_RESUME,
    XS_SET_TARGET
o xen-api-libs.hg/xb/op.ml:
  21 entries; tail is:
        | Watchevent            -> "WATCH_EVENT"
        | Error                 -> "ERROR"
        | Isintroduced          -> "IS_INTRODUCED"
        | Resume                -> "RESUME"
        | Set_target            -> "SET_TARGET"
        | Restrict              -> "RESTRICT"
o Additionally there is a relict (??) [1]:
  20 entries; tail is
    XS_WATCH_EVENT,
    XS_ERROR,
    XS_IS_DOMAIN_INTRODUCED,
    XS_RESUME,
    XS_RESTRICT

I'm a little bit confused - can anybody please tell me which is the
correct set?  Why are there differences (i.e. why differs the linux  
pvops kernel one from the xc one)?  Is there a XS_RESTRICT or not?
Kind regards - Andreas Florath


[1]  
http://lists.xensource.com/archives/cgi-bin/extract-mesg.cgi?a=xen-devel&m=2008-05&i=1209573173.32716.62.camel%40zakaz.uk.xensource.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel