[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [PATCH] Update cr3 in PAE mode when guest walk succeed but shadow walk fails



On 10/21/2009 11:50 AM, Tim Deegan wrote:
Hi,

At 10:46 +0100 on 21 Oct (1256121960), Paolo Bonzini wrote:
I suppose this patch is also needed when running 32-on-64.  In that
case, shouldn't the test be

#if GUEST_PAGING_LEVELS>= 3

rather than "== 3"?

No, '==' is correct.  GUEST_PAGING_LEVELS refers to the layout of the
_guest's_ pagetables, not the shadows.  GUEST_PAGING_LEVELS == 4 means
the guest is using full 64-bit pagetables, which don't have this quirk.

Right, I should have read arch/x86/mm/shadow/Makefile.

Thanks,

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.