[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4 of 7] minios: fix minios console

On Mon, 12 Oct 2009, Mick Jordan wrote:
> On 10/12/09 10:20 AM, Stefano Stabellini wrote:
> > MiniOS' console_print tries to expand '\n' into "\n\r" in place, causing
> > page faults if the string resides in text.
> > Use a duplicate of the string instead.
> >   
> Are you sure this is even necessary? I removed this in my GUK extension 
> of MiniOS with no apparent effect. The actual push to remove it was 
> observing that when "piping" the output of one GUK (JVM) guest to 
> another, the "\n\r" was being treated as two line feeds by the Java 
> runtime. Why? Because it is "\r\n" that is historically reduced to "\n", 
> and not "\n\r". In any event in the Xen/Unix environment there should be 
> no need for the expansion at all. And it really helped to clean up the 
> console code.

The expansion of \n in \r\n is for consistency with linux ttys, but you
are right about the fact that minios actually substitutes \n with \n\r,
and this is definitely another bug.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.