[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [PATCH 3/5] x86/pvclock: add vsyscall implementation

On 10/12/2009 09:13 PM, Jeremy Fitzhardinge wrote:
On 10/12/09 11:29, Avi Kivity wrote:
Good catch.  Doesn't that invalidate rdtscp based vgettimeofday on
non-virt as well (assuming p == cpu)?
The tsc clocksource assumes the tsc is (mostly?) synced; it doesn't use
rdtscp or make any attempt at per-cpu corrections.

So it's broken or disabled when that assumption is wrong? We could easily fix that now. Might even reuse the pvclock structures.

I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.