[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][PV-ops][PATCH 2/2] VNIF(netfront): Using smart polling instead of event notification.

On Thu, 2009-10-01 at 01:09 +0100, Xu, Dongxiao wrote:
> - Netfront uses a timer to poll the ring instead of event channel
> notification. If guest is transferring data, the timer will start
> working and periodicaly send/receive data from ring. If guest is
> idle and no data is transferring, the timer will stop working
> automatically. It will restart again once there is new data
> transferring.

Doesn't the RING_PUSH_REQUESTS_AND_CHECK_NOTIFY macro already give
effectively this behaviour?

Assuming your patch adds further benefit over CHECK_NOTIFY isn't this
similar to what NAPI does, is there any reason not to use the NAPI
infrastructure in the kernel to implement it?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.