Re: [Xen-devel] [PATCH] Include in balloon page tracking only PFNs which are marked as RAM in E820.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Aug 20, 2009 at 05:02:57PM +0100, Gianluca Guida wrote:
> Hi,
> 
> Ok, by looking at this patch it's clear that you are testing with a
> kernel that tries to allow kernels to boot ballooned.
> 
> In this case the patch is correct. Since the patch is actually
> reverted, I think we should wait to apply it until I succeed to
> reproduce the bug that caused Jeremy to revert it.

You are talking about the 7394b25905929a92e51771b832ee67b70ccebcf0 patch?
I will wait and if this patch is still needed I will send it out to 
LKML/xen-devel
with your style comment.


>  > > +                int is_ram = page_is_ram(pfn);
> 
> Do you really need to declare this as a variable? couldn't you put the

Not at all. Right after I sent it out I realized it would have been looking
better without.

> expression in the if statement?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel