[Xen-devel] RE: [PATCH][ioemu] support the assignment of the VF of Intel 82599 10GbE Controller

["Cui, Dexuan" <dexuan.cui@xxxxxxxxx>]

Ian Jackson wrote:
> Cui, Dexuan writes ("[PATCH][ioemu] support the assignment of the VF
> of Intel 82599 10GbE Controller"): 
>> The datasheet is available at
>> http://download.intel.com/design/network/datashts/82599_datasheet.pdf
>> 
>> See 'Table 9.7. VF PCIe Configuration Space' of the datasheet, the
>> PCI Express Capability Structure of the VF of Intel 82599 10GbE
>> Controller looks trivial, e.g., the PCI Express Capabilities
>> Register is 0, so the Capability Version is 0 and
>> pt_pcie_size_init() would fail. 
>> 
>> We should not try to expose the PCIe cap of the device to guest.
> 
> I've applied this for now but it seems a bit ugly to code in the
> device IDs in this way.
Thanks.

>  Couldn't we instead detect this situation
> programmatically ?  Alternatively, if this is going to happen for
> other devices, do we want to provide a proper whitelist in the form of
> a table ?
Using the patch (yes, that's a quirk) I think we can have the least change.
I'm not sure if there are other devices having the same issue.
I think we can wait to see if there are so many such devices that we can make a 
table. :-)

Thanks,
-- Dexuan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel