RE: [Xen-devel] [pvops-dom0] Adding MCA logging support in pv_ops

["Ke, Liping" <liping.ke@xxxxxxxxx>]

Hi, Christoph
Please see my below comments.

And also, I found some interfaces are different in pv_ops kernel such as 
GUEST_HANDLE related. Seems we can't keep the same copy of common
file between XEN and GUEST.  We have to do slight changes to the XEN 
file before copying it to guest kernel.

And also, for the header file, I modified a little according to Andi's feedback
such as gigantic macros will be unacceptable according to kernel code 
conventions, etc. So I modify x86_mcinfo_lookup into inline function.

I will resend the new patch to all of you for further feedback. After the patch 
is accepted, I will sync the modified head file back to XEN for consistency.

Thanks a lot for your help!
Criping



Christoph Egger wrote:
> Hi Ke Liping!
> 
> The xen mca public header needs some comment updates in the xen tree
> first before it populates to the guests:
Yes and thanks!
> 
> In line 102, uncorrectable errors are not reported via nmi handlers.
> Please update the comment to match the code.
> 
OK, I will modify this comment

> In struct mcinfo_recovery, it is not obvious that the REC_ACTION_*
> flags are intended to be used in action_flags. Please add a comment
> to make this clear. 
> 
> In struct mcinfo_recovery, it is not obvious that the MC_ACTION_*
> flags are intended to be used in action_types. Actually are these
> flags? 

OK, I will add comments on this

> These are defined as a bitfield, but the union can't store more than
> one action. Please add a comment to clarify this.
> 

Currently, We only support one action per bank. Do you have requirement
on multiple actions per bank?

> For xen_mc_notifydomain, it is not clear if this has to be used
> before or after acknowledging the fetched telemetry. Please update
> the comment 
> to clarify this.
> 
> In xen_mc_notifydomain, the comment this the flags field may contain
> XEN_MC_TRAP which doesn't exist. Please update the comment.
> 
According to the latest do_mca hypercall implementation, seems
XEN_MC_notifydomain is unsupported, so I never use this hypercall.
Also, I did not see XEN_MC_CORRECTABLE definition in current code too. 
So I will remove both of them in comments here. 
When this hypercall is implemented, the author should update this comments here?

> Christoph
> 
> 
> 
> On Thursday 30 July 2009 07:15:05 Ke, Liping wrote:
>> Hi, Jeremy and Keir
>> 
>> This patch is backport from DOM0 cs902
>> 
>> When an MCE/CMCI error happens (or by polling), the related error
>> information will be sent to DOM0 by XEN. This patch will help to
>> fetch the xen-logged information by hypercall and then convert
>> XEN-format log into Linux format MCELOG. It makes using current
>> available mcelog tools for native Linux possible.
>> 
>> With this patch, after mce/cmci error log information is sent to
>> DOM0, running mcelog tools in DOM0, you will get same detailed
>> decoded mce information as in Native Linux.
>> 
>> Signed-Off-By: Liping Ke <liping.ke@xxxxxxxxx>
>> Signed-Off-By: Yunhong Jiang <yunhong.jiang@xxxxxxxxx>
>> 
>> 
>> Thanks& Regards,
>> Criping


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel