Re: [Xen-devel] [RFC] save image file format CHANGE (minor, but feedback appreciated)

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

Oh yes, it's harder to go earlier than the p2m data. But going before the
(possibly multiple rounds of) data pages is easy.

 -- Keir

On 30/07/2009 23:59, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> Well for PV guests, the p2m table is definitely assumed
> to be first.  Are you saying, I can/should put the tmem
> stuff between the p2m table and the mapped data pages?
> If so, cool, I will give that a try.   Thanks!
> 
> Dan
> 
>> -----Original Message-----
>> From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>> Sent: Thursday, July 30, 2009 4:42 PM
>> To: Dan Magenheimer; Xen-Devel (E-mail)
>> Cc: Tim Deegan; Gianluca Guida; Stefano Stabellini; John Levon;
>> Stefano@xxxxxxxxxxxxxxxxxxxx
>> Subject: Re: [Xen-devel] [RFC] save image file format CHANGE
>> (minor, but
>> feedback appreciated)
>> 
>> 
>> On 30/07/2009 23:05, "Dan Magenheimer"
>> <dan.magenheimer@xxxxxxxxxx> wrote:
>> 
>>> It appears that the "next negative number as marker"
>>> mechanism only works for data that trails the last
>>> iteration of (mapped) pages, and thus works only after
>>> the domain has been suspended.  (True?)
>> 
>> No. It so happens that all such markers are emitted after
>> saved pages right
>> now, but you can see in xc_domain_restore.c that markers are
>> detected right
>> at the top of the read pages loop. You could add a new marker, emit it
>> before any pages in xc_domain_save.c, and pick it up just fine in the
>> restore loop. You'd read the rest of your stuff and act on
>> it, then do a C
>> 'continue' to kick off the next loop iteration, which would
>> presumably start
>> reading ordinary saved memory pages.
>> 
>> Your patch is definitely not required.
>> 
>>  -- Keir
>> 
>> 
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel