Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 30/07/2009 10:12, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> Make (set|get)_xen_guest_handle() always available.
> This avoids code snippets in the guest like this:
> 
> #if __XEN_ITNERFACE_VERSION__ >= 0x00030201
> set_xen_guest_handle(hnd, val);
> #else
> hnd = val;
> #endif

Actually I don't see why you'd have code like this. *You*, the guest, gets
to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so
ifdef'ing based on it in the guest is stupid.

Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest
handles, and then remove your ifdefs. Simple.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel