Re: [Xen-devel] [PATCH] blktap2: Remove set() for Python 2.3

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

How about creating a file which includes the followings
and import it?
 
+# for 2.3 compatibility
+try:
+    set()
+except NameError:
+    from sets import Set as set

On Tue, Jul 21, 2009 at 01:11:39PM +0900, KUWAMURA Shin'ya wrote:
> Hi,
> 
> >>>>> On Tue, 21 Jul 2009 13:41:59 +1000
> >>>>> horms@xxxxxxxxxxxx(Simon Horman)  said:
> > 
> > On Fri, Jul 17, 2009 at 04:26:38PM +0900, KUWAMURA Shin'ya wrote:
> >
> > > This removes set() for Python 2.3, since set() is added from Python 2.4.
> > set() seems to be used in a number of other places in the code.
> > Is that a problem?
> 
> They cause a problem only when the corresponding feature is used.
> # XenAPI, ACM, etc.
> 
> But starting xend failed by the following code:
> > tools/python/xen/util/pci.py:    if len(l) != len(set(l)):
> 
> I removed it on weekly testing ad hoc.
> 
> Best regards,

-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel