Re: [Xen-devel] [PATCH] minios: minor buildsystem fixes

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 15/07/2009 10:42, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> Attached patch changes MiniOS.mk and tools/Rules.mk
> use the OS settings we build on.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

This may need some thought. Using XEN_OS in some places and open coding
'uname -s' in others is just not nice and is fragile.

Since stubdom is not being built in its own chroot, does it make sense for
it to override XEN_OS at all? Should we keep that as 'build host OS'? The
change around LFS in tools/Rules.mk could be indicative of a deeper issue --
information about arbitrary (non-GNU) host environments leaking into
binaries which are actually targetting GNUish minios. Can the current
approach work safely for NetBSD, Solaris, ... build hosts?

So I throw this one to Stefano/Samuel. ;-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel