[Xen-devel] [PATCH] x86,hvm: fix a potential domain_lock leak

[Kouya Shimura <kouya@xxxxxxxxxxxxxx>]

Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

diff -r 4448fae52553 xen/arch/x86/hvm/hvm.c
--- a/xen/arch/x86/hvm/hvm.c    Mon Jun 08 12:24:14 2009 +0100
+++ b/xen/arch/x86/hvm/hvm.c    Fri Jun 12 15:30:49 2009 +0900
@@ -512,11 +512,13 @@ static int hvm_load_cpu_ctxt(struct doma
     vc = &v->arch.guest_context;
 
     /* Need to init this vcpu before loading its contents */
+    rc = 0;
     domain_lock(d);
     if ( !v->is_initialised )
-        if ( (rc = boot_vcpu(d, vcpuid, vc)) != 0 )
-            return rc;
+        rc = boot_vcpu(d, vcpuid, vc);
     domain_unlock(d);
+    if ( rc != 0 )
+        return rc;
 
     if ( hvm_load_entry(CPU, h, &ctxt) != 0 ) 
         return -EINVAL;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel