Re: [Xen-devel] Re: [PATCH] xend: Update info['platform']['pci']

[Simon Horman <horms@xxxxxxxxxxxx>]

On Mon, Jun 01, 2009 at 01:08:09PM +0900, Masaki Kanno wrote:
> Thu, 28 May 2009 20:46:31 +1000, Simon Horman wrote:
> 
> >On Thu, May 28, 2009 at 04:01:50PM +0900, Masaki Kanno wrote:
> >Content-Description: Mail message body
> >> Hi,
> >> 
> >> This patch updates info['platform']['pci'] for PCI devices assignment 
> >> to domains.
> >> 
> >> When a domain is started, xend confirms by using xc.test_assign_device 
> >> whether PCI devices can be assigned to the domain. 
> >> For the confirmation, info['platform']['pci'] must be an appropriate 
> >> value.  However, info['platform']['pci'] may be not appropriate. 
> >> Because info['platform']['pci'] isn't almost always updated even if 
> >> the PCI device configuration of the domain was changed by using 
> >> xm pci-attach/detach. 
> >> This patch updates info['platform']['pci'] to the appropriate value 
> >> when domains are started.
> >
> >Hi Kanno-san,
> >
> >I am curious to know how you exercise this code.
> >Did you notice a bug under some conditions?
> 
> Hi Simon,
> 
> Sorry for late response.
> 
> I noticed the bug when I tried the following operations.
> 
>  1) xm new vm1
>  2) xm list --long vm1
>     (domain
>     <<snip>>
>         (image
>             (hvm
>     <<snip>>
>                 (pci ((0x0 0x01 0x00 0x0 0x6 )))
>  3) xm pci-attach vm1 00:1a.0 7
>  4) xm list --long vm1
>     (domain
>     <<snip>>
>         (image
>             (hvm
>     <<snip>>
>                 (pci ((0x0 0x01 0x00 0x0 0x6 )))
> 
> The value of /domain/image/hvm/pci is a value of info['platform']['pci'].
> The value wasn't updated when I attached the PCI device to the domain by 
> using xm pci-attach.
> 
> The value is updated by my patch.  Nonetheless, the value isn't still 
> updated when xm pci-attach/detach are executed.  The value is updated 
> when starting domains.

Understood. Do you think that also needs to be fixed?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel