[Xen-devel] [patch] [qemu-xen] pass-thorugh: porvide leading zero for vdevfn

[Simon Horman <horms@xxxxxxxxxxxx>]

This is consistent with the format used elsewhere.

At this time this inconsistency manifests in the output of pci-list
for functions that have been hot-plugged.

e.g.

Without this patch:

# xm pci-list debian
VSlt domain   bus   slot   func
0x03 0x0000   0x01  0x00   0x0    
0x07 0x0000   0x01  0x00   0x1    
# xm pci-attach debian 00:1b.0
# xm pci-list debian
VSlt domain   bus   slot   func
0x03 0x0000   0x01  0x00   0x0    
0x07 0x0000   0x01  0x00   0x1    
0x5  0x0000   0x00  0x1b   0x0   

With this patch:

# xm pci-list debian
VSlt domain   bus   slot   func
0x03 0x0000   0x01  0x00   0x0    
0x07 0x0000   0x01  0x00   0x1    
# xm pci-attach debian 00:1b.0
# xm pci-list debian
VSlt domain   bus   slot   func
0x03 0x0000   0x01  0x00   0x0    
0x07 0x0000   0x01  0x00   0x1    
0x05 0x0000   0x00  0x1b   0x0   


While the pci-list output could be unified inside xm or xend by,
for example parsing the string as an integer and then formating it
as a string, there seems to be no disadvantage in making the
string representation used consistent.

Cc: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Cc: Dexuan Cui <dexuan.cui@xxxxxxxxx>
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Index: ioemu-remote/hw/piix4acpi.c
===================================================================
--- ioemu-remote.orig/hw/piix4acpi.c    2009-05-20 11:15:14.000000000 +1000
+++ ioemu-remote/hw/piix4acpi.c 2009-05-20 11:28:14.000000000 +1000
@@ -508,7 +508,7 @@ void acpi_php_add(int slot)
     power_on_php_slot(slot);
 
     /* tell Control panel which slot for the new pass-throgh dev */
-    sprintf(ret_str, "0x%x", slot);
+    sprintf(ret_str, "0x%02x", slot);
     xenstore_record_dm("parameter", ret_str);
 
     /* signal the CP ACPI hot insert done */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel