[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] disallow duplicate pci device strings in guest config file


  • To: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Fri, 15 May 2009 12:44:37 +0100
  • Cc:
  • Delivery-date: Fri, 15 May 2009 04:44:37 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcnVUKywB4Q5NpcfRuKxiLcTkuwu4gAAdlgc
  • Thread-topic: [PATCH] disallow duplicate pci device strings in guest config file

Why is the right answer not: Don't do that, then?

 -- Keir

On 15/05/2009 12:31, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> When we specify duplicate pci device strings in guest config file, like
> pci=['01:00.0', '01:00.0'], or  pci=['01:00.0', '0000:01:00.0'], or
> pci=['01:00.0', '0000:01:00.0@7'],
> xend doesn't detect this case and passes the pci string to ioemu and ioemu
> invokes register_real_device() twice for the same physical device and this
> could cause unexpected behavior.
> 
> The patch detects this case and makes the domain construction fail.
> 
> Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.