Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Wednesday 29 April 2009 17:30:47 Ian Jackson wrote:
> Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for 
build/install system"):
> > Can you send me the output of
> > find dist/install ? Then I can tell you.
>
> I don't have it to hand but stuff had moved into usr/local from usr,
> possibly amongst other changes.
>
> > Did you set PREFIX explicitely or did you use the default values ?
>
> I did not set PREFIX.
>
> > > Did you do a similar test ?
> >
> > I run my tests with clean rebuilds from the toplevel xen directory with
> > gmake dist or PREFIX="/usr/local" gmake dist
>
> The purpose of your changes is to plumb PREFIX through to the qemu
> build system.  But I think you should also test that a default build
> remains unchanged.

I figured out why a default build installs ioemu into /usr/local with
my patch: PREFIX is empty and ioemu's configure sets prefix
to /usr/local if prefix is empty.

Attached patch fixes this (and applies to the xen-tree). It always passes 
PREFIX to xen-setup and xen-setup-stubdom.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Attachment: xen_ioemu_prefix.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel