[Xen-devel] Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core

[Gerd Hoffmann <kraxel@xxxxxxxxxx>]

Blue Swirl wrote:
> On 4/2/09, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
>> This patch adds infrastructure for xen backend drivers living in qemu,
>>  so drivers don't need to implement common stuff on their own.  It's
>>  mostly xenbus management stuff: some functions to access xentore,
>>  setting up xenstore watches, callbacks on device discovery and state
>>  changes, handle event channel, ...
>>
>>  Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> 
>>  + *  You should have received a copy of the GNU General Public License
>>  + *  along with this program; if not, write to the Free Software
>>  + *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  
>> USA
> 
> The address is now 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

Will fix.

>>  +    if (NULL == node  ||  0 == strcmp(node, "online")) {
>>  +       if (-1 == xenstore_read_be_int(xendev, "online", &xendev->online))
> 
> This style is alien.

Oops.  Still one of them.  I though I've killed them all, will check again.

cheers,
  Gerd

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel