Re: [Xen-devel] Re: [PATCH 2/2] ioemu: make management of PCI D-states by guest optional

[Kouya Shimura <kouya@xxxxxxxxxxxxxx>]

Yuji Shimada writes:
> Why are Data_Scale field and Data_Select field emulated?

No reason, I intended that emu_mask and ro_mask become
the same as before your PCI D-state patch.

> I think we can pass-through them as follows.
> 
> On the other hand, No_Soft_Reset field needs to be emulated and fixed
> to 1. The reason is PowerState field is emulated, that means guest
> software can change power state, but actual power state of device is
> not changed. So internal reset never occurs.
> 
> As a result, the code will be as the following.
> 
> read:
>       valid_emu_mask |= PCI_PM_CTRL_STATE_MASK |
>              PCI_PM_CTRL_NO_SOFT_RESET;
> 
> write:
>       uint16_t emu_mask = reg->emu_mask | PCI_PM_CTRL_STATE_MASK |
>              PCI_PM_CTRL_NO_SOFT_RESET;
>       uint16_t ro_mask = reg->ro_mask;

Thank you for pointing out. I'll fix it.

Thanks,
Kouya

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel