Re: [Xen-devel] [PATCH] ioemu : add flush in ide_unplug_harddisks()

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] ioemu : add flush in 
ide_unplug_harddisks()"):
> Tomonari Horikoshi wrote:
> > I think the "flush" is necessary. 
> > When "ioemu ide device" changes into "vbd" by "ide_unplug_harddisks()". 
> 
> I don't think that calling bdrv_aio_flush is a good idea since it is
> asyncronous and right after the call we are going to close the device
> without waiting for completion.

Yes, bdrv_aio_flush is wrong I think.

This seems related to the discussion we had in January.  As I wrote
in
 http://lists.xensource.com/archives/html/xen-devel/2009-01/msg00165.html
it seems to me that the guest should know about be able to flush
for itself ?  After all we implement the IDE flush cache command.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel