Re: [Xen-devel] [PATCH 1 of 3] fix S3 suspend error

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 23/02/2009 05:15, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> Xen owns a few devices with most as system class, so for
>> simplicity interrupt is disabled from start. It's not worthy of touching
>> this flow for this simple spinlock issue, imo. :-)
> 
> Can you point out any core devices in modern Linux 2.6 which implement the
> suspend_late() or *_noirq() callbacks (those appear to be the ones handled
> in device_power_down() with IRQs disabled)? They seem very obsolete/legacy,
> and looks to me like we could unconditionally *not* disable IRQs rather than
> unconditionally disabling them.

Oh, yes, now I see the sysdev_suspend() stuff. Okay, I agree with the
patches then.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel