Re: [Xen-devel] [PATCH 3/5] setup_irq/request_irq/free_irq fixups

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 06/02/2009 11:24, "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx> wrote:

>>> Make setup_irq/request_irq/free_irq take vector param instead of
>>> irq param
> 
>> Do you really think that's an improvement?
> 
> Yes.  Some interrupts, e.g., for handling IOMMU faults, do not need to
> be associated with a pirq.  They just need to have a vector allocated
> to them.  The way this used to work, the caller would have to invent a
> IRQ to go with the vector (typically irq := vector) befor calling the
> function.

My reading of the patch was that you simply pushed irq_to_vector() out into
every caller. I therefore just took the ->shutdown() fix for free_irq() and
dropped the rest. I checked in the rest of your patches.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel