[Xen-devel] Re: [patch 0/4]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 19/12/2008 06:09, "Ke, Liping" <liping.ke@xxxxxxxxx> wrote:

> Hi, All
> 
> Following 4 patches are for enabling CMCI of Intel CPUs in XEN.

These patches are a mess. You can't apply them one by one and build Xen at
each intermediate step. Please properly divide into proper logical units.
For example, the change to stop_machine_run(), and fixes to every caller,
should be one single patch (probably the first patch). The patch to remove
the old MCE stuff either needs to be in the same patch that adds the new
support, or at least you need to fix up Makefiles etc so that applying that
patch alone does not break the build.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel