Re: [Xen-devel] [PATCH] Adjust time init sequence

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 11/12/2008 00:23, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

>> Is it really safe to use NOW() before init_percpu_time()? Seems dodgy.
> 
> Where did you mean by using NOW before init_percpu_time?
> I moved do_settime earlier but with a zero system stamp now
> which matches the line behind to init stime_platform_time to zero.
> To me there's no difference to initialize wallclock at zero point
> or sometime after with a NOW() drift, which should cause similar
> result to wc_sec/wc_nsec.

init_platform_time() -> plt_overflow() -> NOW()

Perhaps the above is safe though? Will NOW() return zero for an
uninitialised per-cpu time sstructure (since stime_local_stamp and tsc_scale
are both zero)?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel