Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re: [Xen-devel] [PATCH 2/2] linux/x86: use shared page indicating the need for an EOI notification)

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 09/12/2008 10:54, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>>>> Isaku Yamahata <yamahata@xxxxxxxxxxxxx> 09.12.08 11:43 >>>
>> You are the first person to pass the kernel symbol address
>> to virt_to_machine() in arch independent code.
>> Is there any necessity to allocate pirq_needs_eoi statically?
>> (except it did before)
> 
> Perhaps not - avoiding the possible allocation failure (-> BUG()) and the
> extra indirection were the main reasons I kept it allocated statically.
> 
>> If no, can we allocate the pages for them dynamically?
>> Then the issue will go away.
> 
> Indeed.

Yes please. Just do this and be done. It's a one-off start-of-day allocation
which, if it fails, means you're screwed anyway.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel