Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re: [Xen-devel] [PATCH 2/2] linux/x86: use shared page indicating the need for an EOI notification)

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Wed, Dec 03, 2008 at 10:08:50AM +0000, Keir Fraser wrote:
> On 03/12/2008 09:59, "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx> wrote:
> 
> > On the other hand on ia64 MMU is fully virtualized (i.e. auto translated
> > phsymap mode enabled) and DMA is paravirtualized.
> > So addresses for MMU and DMA have to be distinguished.
> > xxx_to_machine() is used for MMU and xxx_to_bus() is used for DMA.
> 
> If you are fully virtualised then gmfn should mean gpfn, and
> arbitrary_virt_to_machine() is correct, isn't it? I can't see a situation
> where arbitrary_virt_to_machine() wouldn't correctly give you a gmfn (after
> all, it gets you a machine address in guest context, as its name describes
> :-). 

Oh, you are quite right.
Do you agree to rename PHYSDEVOP_pirq_eoi_mfn to PHYSDEVOP_pirq_eoi_gmfn?

-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel