[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] conditionalize PCI reassign code



Keir Fraser wrote:


On 17/10/08 08:27, "Zhao, Yu" <yu.zhao@xxxxxxxxx> wrote:

As you observed the build error - why don't you provide at least the
error the compiler generated? That might make it possible to provide a
fix quickly.
+#ifdef CONFIG_PCI_REASSIGN
  extern int reassign_resources;
  extern int is_reassigndev(struct pci_dev *dev);
  extern void pci_update_bridge(struct pci_dev *dev, int resno);
+#else
+#define reassign_resources 0
+#define is_reassigndev(dev) 0
+#endif

When the CONFIG_PCI_REASSIGN is not set, e.g., a domU kernel, the
following line fails to be compiled (drivers/pci/quirks.c):

int reassign_resources = 0;

Ah, the automated tests only build the -xen config.

 -- Keir



Actually I happened to get it by misusing a native kernel config ...

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.