[Xen-devel] Re: timer_mode default change?!?

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

Actually I thought we'd agreed to change the timer_mode default to 1. Is
there a better value? Zero seems a poor default to return to.

 -- Keir

On 30/9/08 21:25, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> Huh?  "Most guests" means Windows?  AFAIK, *no* Linux hvm
> guest prefers timer_mode==1.
> 
>> -----Original Message-----
>> From: Xen patchbot-unstable
>> [mailto:patchbot-unstable@xxxxxxxxxxxxxxxxxxx]
>> Sent: Tuesday, September 30, 2008 9:00 AM
>> To: xen-changelog@xxxxxxxxxxxxxxxxxxx
>> Subject: [Xen-changelog] [xen-unstable] hvm: Default timer_mode=1 (do
>> not delay virtual time for missed
>> 
>> 
>> # HG changeset patch
>> # User Keir Fraser <keir.fraser@xxxxxxxxxx>
>> # Date 1222445376 -3600
>> # Node ID 1420a6649cfa2963f1d71956756c922a3b671ae6
>> # Parent  840c0c3c185ae2b0baeceba7caf2f420a44f116d
>> hvm: Default timer_mode=1 (do not delay virtual time for missed
>> ticks). Most guests prefer this mode compared with screwing with
>> progress of virtual time.
>> 
>> Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
>> ---
>>  tools/python/xen/xend/XendConfig.py |    2 +-
>>  tools/python/xen/xm/create.py       |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff -r 840c0c3c185a -r 1420a6649cfa
>> tools/python/xen/xend/XendConfig.py
>> --- a/tools/python/xen/xend/XendConfig.py Fri Sep 26
>> 15:33:51 2008 +0100
>> +++ b/tools/python/xen/xend/XendConfig.py Fri Sep 26
>> 17:09:36 2008 +0100
>> @@ -441,7 +441,7 @@ class XendConfig(dict):
>>  
>>          if self.is_hvm():
>>              if 'timer_mode' not in self['platform']:
>> -                self['platform']['timer_mode'] = 0
>> +                self['platform']['timer_mode'] = 1
>>              if 'rtc_timeoffset' not in self['platform']:
>>                  self['platform']['rtc_timeoffset'] = 0
>>              if 'hpet' not in self['platform']:
>> diff -r 840c0c3c185a -r 1420a6649cfa tools/python/xen/xm/create.py
>> --- a/tools/python/xen/xm/create.py Fri Sep 26 15:33:51 2008 +0100
>> +++ b/tools/python/xen/xm/create.py Fri Sep 26 17:09:36 2008 +0100
>> @@ -214,7 +214,7 @@ gopts.var('hpet', val='HPET',
>>            use="Enable virtual high-precision event timer.")
>>  
>>  gopts.var('timer_mode', val='TIMER_MODE',
>> -          fn=set_int, default=0,
>> +          fn=set_int, default=1,
>>            use="""Timer mode (0=delay virtual time when ticks
>> are missed;
>>            1=virtual time is always wallclock time.""")
>>  
>> 
>> _______________________________________________
>> Xen-changelog mailing list
>> Xen-changelog@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-changelog
>> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel