Re: [Xen-devel] [PATCH] microcode update support for AMD CPUs

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Christoph Egger writes ("[Xen-devel] [PATCH] microcode update support for AMD 
CPUs"):
> +     edx = (unsigned int)((unsigned long)(addr >> 32));

This is wrong.  addr is an unsigned long, ie 32 bits so you are
shifting by >= the word size, which is not permitted.  Helpfully, many
compilers warn about it.

But addr came from this:
        addr = (unsigned long)&uci->mc.mc_amd->hdr.data_code;
surely this cannot be right if you're expecting the address to be
longer than 32 bits in some cases ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel