[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-ia64-devel] Re: [Xen-devel] [PATCH] ioemu-remote: fix cross compilation.



On Fri, Aug 29, 2008 at 10:22:07AM +0100, Ian Jackson wrote:
> Isaku Yamahata writes ("Re: [Xen-ia64-devel] Re: [Xen-devel] [PATCH] 
> ioemu-remote: fix cross compilation."):
> > On Thu, Aug 28, 2008 at 03:39:39PM +0100, Ian Jackson wrote:
> > > I think this is quite ugly really.  We're engaging in a war of
> > > makefiles.  Why can't Rules.mk set the right version of install ?
> > 
> > Yes, it's ugly. How about the followings? Which do you prefer?
> > One candidate is to modify ioemu-remote/Makefile, Makefile.target,
> > another is for the xen-unstable. Making INSTALL overridable
> > isn't intuit...
> 
> I meant that the xen-unstable tree should set INSTALL to the
> cross-install wrapper.

Something like the following?
I didn't touch SunOS.mk intentionally because I don't have
the environment. And I'll leave it to sun guys.


build system: make INSTALL cross aware.

When cross compiling, use cross-install instead of the install command.

Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>

diff -r 0d7da13ec71b config/StdGNU.mk
--- a/config/StdGNU.mk  Thu Aug 21 16:21:10 2008 +0900
+++ b/config/StdGNU.mk  Fri Aug 29 19:11:06 2008 +0900
@@ -16,7 +16,11 @@
 # Allow git to be wrappered in the environment
 GIT        ?= git
 
+ifneq ($(CROSS_COMPILE),)
+INSTALL      = $(XEN_ROOT)/tools/cross-install
+else
 INSTALL      = install
+endif
 INSTALL_DIR  = $(INSTALL) -d -m0755 -p
 INSTALL_DATA = $(INSTALL) -m0644 -p
 INSTALL_PROG = $(INSTALL) -m0755 -p

-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.