[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH][XEN] public header: portability

  • To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Thu, 21 Aug 2008 11:18:41 +0100
  • Cc:
  • Delivery-date: Thu, 21 Aug 2008 03:19:09 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AckDdtO6El+bnm9qEd2gBAAX8io7RQAAHTSP
  • Thread-topic: [Xen-devel] [PATCH][XEN] public header: portability

On 21/8/08 11:15, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

> On 21/8/08 11:03, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
>> Attached patch defines xen_*mb() macros for NetBSD.
>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> Since this has presumably never worked unmodified for NetBSD, it's not a
> compatibility issue. You should simply specify __XEN_INTERFACE_VERSION__ >=
> 0x00030208 and fix up any small build breakages that this causes in the NetBSD
> kernel sources.

Actually I suspect you're not specifying __XEN_INTERFACE_VERSION__ at all
right now. The easiest way to do so is to add it to your CPPFLAGS
(-D__XEN_INTERFACE_VERSION__=<whatever>), or NetBSD build system equivalent,
then it definitely gets defined correctly everywhere that you include Xen
public header files.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.