Re: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction-flag?

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 19/8/08 19:33, "Byrne, John (HP Labs)" <john.l.byrne@xxxxxx> wrote:

> Wrong assert. I confused you, my fault. The ASSERT(!reverse) I figured out.
> 
> The ASSERT I was concerned about is this:
> 
>     if ( (hvmemul_ctxt->ctxt.regs->eflags & X86_EFLAGS_DF) && (*reps > 1) )
>     {
>         ASSERT(offset >= ((*reps - 1) * bytes_per_rep));
> 
> However, I just read truncate_ea_and_reps() in the emulator which should
> guarantee this.

Yes, I considered giving that one a comment too. Now I will do so.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel