[Xen-devel] [PATCH] stubdom: Fix the Makefile

[Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>]

Ian Jackson wrote:
> Yosuke Iwamatsu writes ("[Xen-devel] [PATCH] stubdom: Fix the Makefile"):
> > While building stubdom, I saw an error.
> >
> >   install: cannot stat `lib/{config,header,pci,types}.h': No such file
> >   or directory
> >
> > It seems brace expansion is not available in some environments, so we
> > had better avoid using it.
> I see that this has been committed already.  However for future
> reference I think a better answer is to say
>    SHELL=/bin/bash
> in some appropriate place.
>
> This kind of brace expansion is an excellent trick for removing
> duplication in Makefile runes and our build system depends on bash
> anyway.
I agree that brace expansion is convenient and sometimes desireble.
One thing I want to clarify is that, does our build system really depend
on bash? Non-linux systems as *BSD and Solaris are not likely to have
bash, so 'SHELL=/bin/bash' won't work. (I usually use a linux box myself
and assuming that bash is always available is O.K. to me, though.)

-- Yosuke

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel