[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver.



Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
>>  +       buffer->data = realloc(buffer->data, buffer->capacity);
> 
> On Qemu, instead of malloc,  qemu_malloc should be used to allocate
> memory. Though there isn't qemu_realloc.

Should I add qemu_realloc then?

>>  +    if (!type || 0 != strcmp(type, "ioemu")) {
> 
> Shouldn't this be "qemu"?

No, "ioemu" is correct.  xend writes that value into xenstore.

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.