Re: [Xen-devel] [PATCH] hvm: Use main memory for video memory. [Was: xend, 8MB video memory and ballooning]

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 31/7/08 14:18, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:

> diff -r 83b3a8a2a4f3 tools/libxc/xc_domain_save.c
> --- a/tools/libxc/xc_domain_save.c Thu Jul 31 12:58:07 2008 +0100
> +++ b/tools/libxc/xc_domain_save.c Thu Jul 31 13:20:02 2008 +0100
> @@ -1112,9 +1112,7 @@ int xc_domain_save(int xc_handle, int io
>                      continue;
>  
>                  /* Skip PFNs that aren't really there */
> -                if ( hvm && ((n >= 0xa0 && n < 0xc0) /* VGA hole */
> -                             || (n >= (HVM_BELOW_4G_MMIO_START >> PAGE_SHIFT)
> -                                 && n < (1ULL<<32) >> PAGE_SHIFT)) /* MMIO */
> )
> +                if ( hvm && n == shared_info_frame )
>                      continue;

What happens if you don't special-case shared_info_frame? I'd've hoped it
would just work... does the extra page of allocation during restore fail?

I'm thinking that the grant tables will be mapped in the I/O hole too, and
that is from 'Xen heap' just like shared_info is. So special-casing one and
not the other sure is odd.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel