[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Fix issue with user-mode writes to ro memory


  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Trolle Selander" <trolle.selander@xxxxxxxxx>
  • Date: Tue, 29 Jul 2008 12:04:01 +0100
  • Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 29 Jul 2008 04:05:34 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:mime-version:content-type; b=Wh2QHXJuEZVwioEgAZHGo+vs0eylmeTb8/YBITWyHRFZ4LdsgZQBW+Ksa3pos5czqd J0tjgvKXVlwP91ZJhDCC9icBhtiLpPx3OuP0fc0rg0FI59ddpdUH/4tXu2w4JuRucvyW VL5U0LYp7ETu149+AA8MrVO2XNuJhdRnW0D94=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

This patch fixes an issue where a guest could get stuck if a write to memory marked p2m_ram_ro happened from user mode. It would get misinterpreted as a user-mode page-table write, and the "dummy write" emulation necessary to skip over the instruction never got done.
In looking into this, I also discovered that the user-mode page-table check is done in two places, the second (in emulate_map_dest) of which can never be reached and is just a waste of cycles. Tim Deegan requested that rather than completely removing that code, I'd leave it in for debug-builds with an added warning-print.

Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxxxxxx <mailto:trolle.selander@xxxxxxxxxxxxx>

Attachment: shadow_user_write_to_ro.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.