[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] x86emulate - fix unintended writeback on cmp/test instructions


  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
  • From: "Trolle Selander" <trolle.selander@xxxxxxxxx>
  • Date: Fri, 25 Jul 2008 12:00:45 +0100
  • Cc:
  • Delivery-date: Fri, 25 Jul 2008 04:01:07 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=FYGSYoRBDeYvJyc3qvFSG2a/J43xcQYGMzPYWtVzMquu11jzsQgzSA/qVrrLGYzAEN LjnDBJj9fRzUiTNvkWpS+CB/PGpWHBCaam5wUXWtQVSYFwdWDBgjpP/yxn6bwcRYMSHt 8cSonupAtYIi7kNfO4QN0eGlKQcS0/hlxjg8M=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

This patch fixes an issue when x86_emulate is called with force_writeback=1 set. It resulted in cmp and test instructions with memory operands to have the mem value written back after instruction emulation finished. This caused false alarms on writes to RO mem, and might have caused other issues if unintended writes occured to device registers in mmio space.

Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxxxxxx <mailto:trolle.selander@xxxxxxxxxxxxx>

Attachment: xen_x86_emulate_prevent_cmp_writeback.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.