[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] [HVM] Fix intra-vga-mem mmio in stdvga.c


  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
  • From: "Trolle Selander" <trolle.selander@xxxxxxxxx>
  • Date: Wed, 23 Jul 2008 13:05:58 +0100
  • Cc:
  • Delivery-date: Wed, 23 Jul 2008 05:06:24 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=cIDj3Y8Rn6YXdeBxvjKiOV/Nqp2n+7mGBQXLjmYgvrSOd8/Xk4P55ruiCmrCtvMQrR gZaBHRTyyUZByW+vNC/Mz3Acl8mooRw8MdtkoIoz3CQJVAy4tflQKO9ypeZyRK+4fN7s JLn5tkbhOF64PsHLQQzycW3WEuTpXviD7BoKM=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

The current stdvga code never checks if the copy_from/to_guest calls fail, and thus silenty fails if both sides of an IOREQ_COPY points into mmio space. This patch fixes this and makes the code correctly handle intra-vga-mem copies, as well as log & turn off caching if some more "exotic" type of mmio (say, copy from vga mem to some other device's iomem), so that such mmio reqs will fall through to regular ioemu where they can hopefully be handled correctly.

In practice, this patch fixes a number of graphical glitches for guests running in standard vga mode, including a corrupted OS/2 boot graphic.

Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxxxxxx>

Attachment: xen_hvm_stdvga_fix.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.