Re: [Xen-devel] [PATCH 1/4] hvm: NUMA guest: extend memops hypercall

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 4/7/08 16:28, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> Have you applied the patches correctly? From 02_numa_guest.patch:
> @@ -115,7 +113,7 @@
>               goto out;
> 
>           page = alloc_domheap_pages(
> -            d, a->extent_order, a->memflags | MEMF_node(node));
> +            d, a->extent_order, a->memflags);
>           if ( unlikely(page == NULL) )
>           {
>               gdprintk(XENLOG_INFO, "Could not allocate order=%d extent:"
> 
> The other use of MEMF_node is in exchange_memory, which is not given any
> NUMA node info from the caller, so this is correct.

When sent a patch sequence I expect the patches to apply and work
independently (when applied one-by-one in order).

Anyway, your second patch changes the default NUMA allocation policy from
allocate on home node for the domain to allocate on node I'm currently
executing on. That would seem a net loss for PV guests (whose builder will
not be explicitly specifying the numa node for allocations).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel